From 977da9f44b1229c975e895f3e10eb9595bd17eb9 Mon Sep 17 00:00:00 2001 From: Tomas <tomasysh@gmail.com> Date: 星期六, 05 八月 2023 17:49:46 +0800 Subject: [PATCH] Fixed: [弱掃] p14.1 Bad use of null-like value --- PAMapp/store/index.ts | 46 ++++++++++++++++++++++++++++++---------------- 1 files changed, 30 insertions(+), 16 deletions(-) diff --git a/PAMapp/store/index.ts b/PAMapp/store/index.ts index 9ddc1b6..211ff88 100644 --- a/PAMapp/store/index.ts +++ b/PAMapp/store/index.ts @@ -87,30 +87,44 @@ @Action async storeConsultantList() { - const localData = getFavoriteFromStorage(); + const localData = getFavoriteFromStorage(); - if (!this.isUserLogin) { - this.context.commit('updateConsultantList', localData) - return; - }; + // 雿輻 Optional Chaining (摰�����批惇�批���) 靘���� null ��� undefined ����� + if (!this.isUserLogin) { + this.context.commit('updateConsultantList', localData); + return; + } + if (localData?.length) { + const addFavoriteAgentList: AddFavoriteConsultantItem[] = localData.map(i => ({ agentNo: i.agentNo, createdTime: i.updateTime })); - if (localData?.length) { - const addFavoriteAgentList: AddFavoriteConsultantItem[] = localData.map(i => ({ agentNo: i.agentNo, createdTime: i.updateTime})); - await queryConsultantService.addFavoriteConsultant(addFavoriteAgentList).then(res => { - localStorage.removeItem('favoriteConsultant') - }) + // 蝣箔�甇交����蝯�� null ��� undefined + const response = await queryConsultantService.addFavoriteConsultant(addFavoriteAgentList); + if (response !== null) { + localStorage.removeItem('favoriteConsultant'); + } else { + throw new Error('queryConsultantService.addFavoriteConsultant returned null-like value.'); } + } - myConsultantService.getFavoriteConsultantList().then(data => { - this.context.commit('updateConsultantList', data); - }) + // 蝣箔�甇交����蝯�� null ��� undefined + const favoriteConsultantList = await myConsultantService.getFavoriteConsultantList(); + if (favoriteConsultantList !== null) { + this.context.commit('updateConsultantList', favoriteConsultantList); + } else { + throw new Error('myConsultantService.getFavoriteConsultantList returned null-like value.'); + } - myConsultantService.getAllGroupByConsultant().then((data) => { - this.context.commit('updateAppointmentGroupByConsultantList', data); - }) + // 蝣箔�甇交����蝯�� null ��� undefined + const groupByConsultantData = await myConsultantService.getAllGroupByConsultant(); + if (groupByConsultantData !== null) { + this.context.commit('updateAppointmentGroupByConsultantList', groupByConsultantData); + } else { + throw new Error('myConsultantService.getAllGroupByConsultant returned null-like value.'); + } } + @Action async removeFromMyConsultantList(agentNo: string) { const left = this.myConsultantList.filter(item => item.agentNo !== agentNo); -- Gitblit v1.8.0