From a8b21cd919b76a548b77ef0ec2d8aee28c8e6b0e Mon Sep 17 00:00:00 2001
From: wayne <wayne8692wayne8692@gmail.com>
Date: 星期二, 23 十一月 2021 10:41:56 +0800
Subject: [PATCH] [update] 修正發送OTP api,將兩個發送方式並成同一個

---
 pamapi/src/main/java/com/pollex/pam/service/OtpWebService.java |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/pamapi/src/main/java/com/pollex/pam/service/OtpWebService.java b/pamapi/src/main/java/com/pollex/pam/service/OtpWebService.java
index 35c9a63..144e202 100644
--- a/pamapi/src/main/java/com/pollex/pam/service/OtpWebService.java
+++ b/pamapi/src/main/java/com/pollex/pam/service/OtpWebService.java
@@ -22,7 +22,8 @@
 
     public OtpResponseDTO sendByPhone(String phone) throws ServiceException, RemoteException {
         OtpWebServicePortBindingStub stub = getOtpWebServicePortBindingStub();
-        log.info("call OtpService snedOtpBySMS, ");
+        log.info("call OtpService sendOtpBySMS, url = {}, systemType = {}, service password = {}, phone = {}",
+            applicationProperty.getOtpWebServiceUrl(), applicationProperty.getOtpWebServiceSystemType(), applicationProperty.getOtpWebServicePassword(), phone);
 
         String[] result =
             stub.sendOtpBySMS(applicationProperty.getOtpWebServicePassword(), applicationProperty.getOtpWebServiceSystemType(), phone);
@@ -32,21 +33,19 @@
 
     public OtpResponseDTO sendByEmail(String email) throws ServiceException, RemoteException {
         OtpWebServicePortBindingStub stub = getOtpWebServicePortBindingStub();
+        log.info("call OtpService sendByEmail, url = {}, systemType = {}, service password = {}, email = {}",
+            applicationProperty.getOtpWebServiceUrl(), applicationProperty.getOtpWebServiceSystemType(), applicationProperty.getOtpWebServicePassword(), email);
 
         String[] result =
             stub.sendOtpByEmail(applicationProperty.getOtpWebServicePassword(), applicationProperty.getOtpWebServiceSystemType(), email);
 
-        final OtpResponseDTO otpResponseDTO = new OtpResponseDTO(result);
-        if(otpResponseDTO.isSuccess()) {
-            return otpResponseDTO;
-        }
-        else {
-            throw new RuntimeException("error code = " + otpResponseDTO.getFailCode() + ", error reason = " + otpResponseDTO.getFailReason());
-        }
+        return new OtpResponseDTO(result);
     }
 
     public OtpResponseDTO verifyOTP(String indexKey, String otpCode) throws ServiceException, RemoteException {
         OtpWebServicePortBindingStub stub = getOtpWebServicePortBindingStub();
+        log.info("call OtpService verifyOTP, url = {}, systemType = {}, service password = {}, indexKey = {}, otpCode = {}",
+            applicationProperty.getOtpWebServiceUrl(), applicationProperty.getOtpWebServiceSystemType(), applicationProperty.getOtpWebServicePassword(), indexKey, otpCode);
 
         String[] result =
             stub.verifyOtp(applicationProperty.getOtpWebServicePassword(), applicationProperty.getOtpWebServiceSystemType(), indexKey, otpCode);
@@ -54,7 +53,7 @@
         return new OtpResponseDTO(result);
     }
 
-    private OtpWebServicePortBindingStub getOtpWebServicePortBindingStub() throws ServiceException {
+    public OtpWebServicePortBindingStub getOtpWebServicePortBindingStub() throws ServiceException {
         OtpWebServiceLocator locator = new OtpWebServiceLocator();
         locator.setOtpWebServicePortEndpointAddress(applicationProperty.getOtpWebServiceUrl());
 

--
Gitblit v1.8.0